Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove low-level fields from methods that return iterators #279

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Aug 10, 2023

Follow up to databricks/databricks-sdk-go#569 and databricks/cli#647

TBD: we need a bit better way to tell that request is a request class.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.25% 🎉

Comparison is base (b82fa01) 52.55% compared to head (22faf72) 52.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
+ Coverage   52.55%   52.81%   +0.25%     
==========================================
  Files          33       33              
  Lines       19823    19879      +56     
==========================================
+ Hits        10418    10499      +81     
+ Misses       9405     9380      -25     
Files Changed Coverage Δ
databricks/sdk/service/catalog.py 51.83% <100.00%> (+0.29%) ⬆️
databricks/sdk/service/compute.py 52.23% <100.00%> (+0.06%) ⬆️
databricks/sdk/service/jobs.py 55.29% <100.00%> (+0.43%) ⬆️
databricks/sdk/service/ml.py 49.83% <100.00%> (+0.81%) ⬆️
databricks/sdk/service/pipelines.py 50.86% <100.00%> (+0.69%) ⬆️
databricks/sdk/service/sql.py 54.98% <100.00%> (+0.44%) ⬆️
databricks/sdk/service/workspace.py 51.90% <100.00%> (+0.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfx nfx linked an issue Aug 14, 2023 that may be closed by this pull request
@nfx nfx added the ergonomics UX of SDK label Sep 25, 2023
@nfx nfx requested a review from mgyucht January 4, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen issues related to generated code do-not-merge ergonomics UX of SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jobs/list limit to match api documentation [FEATURE]
2 participants